fix(share): Set expiration time to end of day (23:59:59)#58128
Conversation
nfebe
requested review from
CarlSchwan,
leftybournes,
provokateurin and
salmart-dev
and removed request for
a team
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Code looks good, but this seems like a rather big change if you ask me. @AndyScherzinger was this discussed somewhere already?
@provokateurin @nfebe no, this is new to me and would need to be discussed. Also looping in @jancborchardt since with current behavior in mind this would be unexpected for people using the feature and understanding its current behavior. |
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
I agree that this would change it to a more expected behavior.
But either way, there needs to be a subline to note that expiration day means end-of-day of your current timezone (or UTC, whatever we define).
AndyScherzinger
left a comment
AndyScherzinger
left a comment
There was a problem hiding this comment.
Approval in the behavior sense: This change in behavior is approved - I did not review the implementation itself (!)
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Also approving behavior design-wise. This is more expected than our current approach.
nfebe
force-pushed
the
fix/share-expiration-date-time
branch
2 times, most recently
from
dbaf5f5 to
5f91dd8
Compare
nfebe
force-pushed
the
fix/share-expiration-date-time
branch
from
5f91dd8 to
707bfc4
Compare
|
/backport to stable33 |
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Integration test failures are related
Shares now expire at the end of the selected day instead of the beginning, allowing access throughout the entire expiration day. Also return actual stored time in API response instead of hardcoded 00:00:00 to prevent timezone-related display issues in the UI. Signed-off-by: nfebe <fenn25.fn@gmail.com>
Update expected values in ManagerTest to reflect the new behavior where share expiration dates are set to 23:59:59 instead of 00:00:00. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
fix/share-expiration-date-time
branch
from
707bfc4 to
ce0d97b
Compare
5 participants
Shares now expire at the end of the selected day instead of the beginning, allowing access throughout the entire expiration day.
Also return actual stored time in API response instead of hardcoded 00:00:00 to prevent timezone-related display issues in the UI.